-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization containerization #10
Merged
Merged
+777
−755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 67.43% 64.93% -2.51%
==========================================
Files 10 10
Lines 562 559 -3
Branches 77 78 +1
==========================================
- Hits 379 363 -16
- Misses 158 172 +14
+ Partials 25 24 -1
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Goulustis wrote a singularity image for samsum running and Ubuntu 18.04 image.
@Goulustis converted the Python class 'AlignmentDat' into the class 'Match' in the C++ extension
_sam_module
. Now, the Match instances can be used in Python, since they're declared as Python objects in the C++ extension. Previously, Match instances would be created for each alignment, converted to lists where each element of the list represented an attribute of Match, then these strings would be used to instantiate AlignmentDat instances. That was super hacky and this is a huge improvement over the previous method. Thanks Matthew!