Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization containerization #10

Merged
merged 26 commits into from
Dec 29, 2020
Merged

Conversation

cmorganl
Copy link
Contributor

@cmorganl cmorganl commented Jul 9, 2020

@Goulustis wrote a singularity image for samsum running and Ubuntu 18.04 image.

@Goulustis converted the Python class 'AlignmentDat' into the class 'Match' in the C++ extension _sam_module. Now, the Match instances can be used in Python, since they're declared as Python objects in the C++ extension. Previously, Match instances would be created for each alignment, converted to lists where each element of the list represented an attribute of Match, then these strings would be used to instantiate AlignmentDat instances. That was super hacky and this is a huge improvement over the previous method. Thanks Matthew!

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #10 into master will decrease coverage by 2.50%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   67.43%   64.93%   -2.51%     
==========================================
  Files          10       10              
  Lines         562      559       -3     
  Branches       77       78       +1     
==========================================
- Hits          379      363      -16     
- Misses        158      172      +14     
+ Partials       25       24       -1     
Impacted Files Coverage Δ
src/samsum/commands.py 64.15% <ø> (ø)
src/samsum/alignment_utils.py 70.83% <22.22%> (-13.71%) ⬇️
src/samsum/file_parsers.py 67.27% <88.88%> (-1.70%) ⬇️
src/samsum/__init__.py 100.00% <100.00%> (ø)
src/samsum/classy.py 78.33% <100.00%> (ø)

@cmorganl cmorganl merged commit 5887dcf into master Dec 29, 2020
@cmorganl cmorganl deleted the optimization_containerization branch December 29, 2020 16:16
@cmorganl cmorganl mentioned this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants