fix: revert deprecation of several constants #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecation of these constants was applied in error. This update removes the `Deprecated` annotations and associated Dart fixes to restore their intended usage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
=======================================
Coverage 62.18% 62.18%
=======================================
Files 34 34
Lines 1145 1145
=======================================
Hits 712 712
Misses 433 433
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The deprecation of these constants was applied by mistake. This PR removes the
@Deprecatedannotations and any related Dart fixes to restore their intended usage.Related Issue
Type of Change
feat– New feature (non-breaking change that adds functionality)fix– Bug fix (non-breaking change that fixes an issue)!– Breaking change (fix or feature that causes existing functionality to change)perf– Performance improvementrefactor– Code refactor (no functionality change)docs– Documentation updatestyle– Code style changes (formatting, renaming, etc.)test– Test update or additionbuild– Build related changesci– CI related changeschore– Chore (maintenance, non-production code change)revert– Revert a previous commit