-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically dispose COM and WinRT objects with NativeFinalizer
#623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halildurmus
added
feature
A new feature or request
winrt
com
Issue with COM support
labels
Dec 17, 2022
halildurmus
force-pushed
the
native-finalizer
branch
from
December 17, 2022 10:19
24f1c73
to
23ca4e5
Compare
halildurmus
commented
Dec 17, 2022
timsneath
reviewed
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments prior to merging; hopefully they're helpful!
timsneath
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Let's do this! :) Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443
Attaches
NativeFinalizer
toIUnknown
objects so that their pointers can be freed automatically by the NativeFinalizer. Note that freeing their pointers is not enough, we actually need to callrelease()
on objects before freeing their pointers so that the resources on the native side can be freed as well. For example, here is a snippet from windows-rs that implements the Drop trait for IUnknown interface.In order to do this automatically with the NativeFinalizer, we need to write a small function in C++ and use it as the NativeFinalizer's callback. The function is going to be something like this:
Bundling native code with Dart packages is a huge pain at the moment. Fortunately, there is an upcoming feature to make this process seamless. Once it is released, we should be able to easily use the above function as a callback for the NativeFinalizer and get rid of the calls to
release()
, and make disposing COM and WinRT objects completely automatic (yay!).Also made some refactor/cleanup in various places.