Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infocenter updates #1286

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Infocenter updates #1286

merged 4 commits into from
Dec 10, 2024

Conversation

florianesser
Copy link
Member

No description provided.

Use hyphenated name `hale-studio Infocenter` so that the file name of the build
artifact starts with `hale-studio-Infocenter` instead of
`halestudio-Infocenter`.
Copy link

github-actions bot commented Dec 6, 2024

This PR cannot be merged yet because a required label is missing: challenged. It needs to be added before this PR can be merged.

Copy link

github-actions bot commented Dec 6, 2024

hale studio builds for this pull request:

Build triggered for commit acbde97.
Artifacts are retained for 14 days.

Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment on potential encoding issue.

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<toc label="hale studio User Guide">
<toc label="hale»studio User Guide">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong or just not correctly displayed here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - looks different in "Conversation" than in "Files changed"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the encoding and it looks good to me in UTF-8. Not sure why it displays wrong on the "Files changed" tab.

@florianesser florianesser merged commit 2b482c2 into master Dec 10, 2024
7 of 8 checks passed
@florianesser florianesser deleted the build/update-infocenter branch December 10, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants