Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user home to integrate java for macOS #221

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Use user home to integrate java for macOS #221

merged 1 commit into from
Sep 24, 2024

Conversation

rennsax
Copy link
Contributor

@rennsax rennsax commented Feb 26, 2024

Fix #213.

To integrate jdk at user home, set java_macos_integration_in_home = yes.

Fix #213.

To install jdk at user home, set `java_macos_integration_in_home = yes`
@mrmeszaros
Copy link

@rennsax Thanks for the effort!

A few points to consider:

  • Add some documentation (to the README.md I'd guess)

    • similarly to the java_macos_integration_enable option
  • Add tests (to the .github/workflows/tests.yml I'd guess)

    • This can ensure that a later feature / change does not break what You'd done
  • I think You almost nailed the naming for the option:

    • starts with java_macos_integration_ - cool
    • however, I'd prefer if it was java_macos_integration_user_home

I hope the maintainer (@halcyon) should be able to help You with these, until then I'll try to test it locally, and give You feedback if I encounter some issues.

@rennsax
Copy link
Contributor Author

rennsax commented May 5, 2024

@mrmeszaros Thanks for your advices! I may struggle some time to deal with the tests.

@rennsax
Copy link
Contributor Author

rennsax commented Sep 24, 2024

I find this repo is not maintained anymore, and I personally do not use asdf now. Closed.

@rennsax rennsax closed this Sep 24, 2024
@halcyon
Copy link
Owner

halcyon commented Sep 24, 2024 via email

@halcyon
Copy link
Owner

halcyon commented Sep 24, 2024

A ping saying you felt this PR was ready to merge would have very likely gotten my attention. I can certainly understand that you may have found something that fits your needs better than ASDF.

@halcyon halcyon reopened this Sep 24, 2024
@halcyon halcyon merged commit b966b6f into halcyon:master Sep 24, 2024
1 of 2 checks passed
@halcyon
Copy link
Owner

halcyon commented Sep 24, 2024

@rennsax thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use user home for MacOS /usr/libexec/java_home integration
3 participants