-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key Binding API #1885
Merged
Merged
Key Binding API #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptions to be added to the help screen
…itional function to filter on key codes
This will also provide access for plugins to respond to |
This is a great addition. Thanks for a well structured PR with docs, comments and all 🙌 |
You’re welcome, glad it was useful. |
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Key Binding API that allows plugins to programmatically add and remove key bindings to Reveal's key handling.
keydown
event listeners that can't be overridden by user defined bindings usingkeyboard
config optionkeydown
event to config.keyboardCondition() to allow plugins to filter keyboard based on keycodes. Use case: the reveal.js-menu plugin blocks Reveal keyboard interaction (using keyboardCondition) when the menu is open but using the key binding API to toggle the menu fails to close the menu unless the 'm' key is allowed to pass through to Reveal.