Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to mute background videos #1360

Merged
merged 10 commits into from
Dec 3, 2015
Merged

Conversation

oslego
Copy link
Contributor

@oslego oslego commented Sep 19, 2015

This pull request adds the muted property to a video element that is used as a slide background.

Using the data-background-video-muted attribute together with data-background-video mutes the video. Useful for videos that can't be edited.

@hakimel
Copy link
Owner

hakimel commented Nov 30, 2015

Great addition. Any chance you can remove the whitespace changes to avoid conflicts? We basically want these changes: oslego@8bbc297?w=1

@oslego
Copy link
Contributor Author

oslego commented Dec 3, 2015

I made the required changes and rebased from latest dev branch. Does this look gook?

@hakimel hakimel merged commit d06981c into hakimel:dev Dec 3, 2015
@hakimel
Copy link
Owner

hakimel commented Dec 3, 2015

Weird, it looks like those whitespace changes still snuck their way in but I went ahead and merged this anyway. Thanks for the PR!

@oslego
Copy link
Contributor Author

oslego commented Dec 3, 2015

I think that happened because of a merge I did with my previously pushed
branch. I'm sorry! End-of-line whitespace removal happens automatically in
my Atom editor. I disabled that for future work.

Thanks for accepting the PR!

On Thu, Dec 3, 2015 at 10:50 AM Hakim El Hattab notifications@github.com
wrote:

Weird, it looks like those whitespace changes still snuck their way in but
I went ahead and merged this anyway. Thanks for the PR!


Reply to this email directly or view it on GitHub
#1360 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants