Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight.js background color is overriden #1290

Closed
shmerl opened this issue Jun 30, 2015 · 2 comments
Closed

highlight.js background color is overriden #1290

shmerl opened this issue Jun 30, 2015 · 2 comments

Comments

@shmerl
Copy link

shmerl commented Jun 30, 2015

In current themes in reveal.js you can't control the background color of the code block. I.e. switching the theme for highlight.js doesn't change the background color. It can be enabled by commenting out explicit coloring in the theme styles. Example for night.css:

.reveal pre code {
  display: block;
  padding: 5px;
  overflow: auto;
  max-height: 400px;
  word-wrap: normal;
/*  background: #3F3F3F;
  color: #DCDCDC; */ }

Is it intended or it's some omission? Leaving background color up to the highlight.js theme gives it more flexibility.

@Delapouite
Copy link

I agree, these values should not be forced. Either by letting highlight.js do the job or at least offers vars to tweak the colors : https://github.com/hakimel/reveal.js/pull/1135/files

@hakimel
Copy link
Owner

hakimel commented Jul 2, 2015

Those styles have been removed.

@hakimel hakimel closed this as completed Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants