fix: Fix include_role with loop

[haidaraM]

Should fix #80

[coveralls]

Coverage decreased (-0.5%) to 94.595% when pulling 940c585 on fix/includeRoleLoop into c65ffcd on main.

[fiskhest]

Hi @haidaraM

My impression is that the changes would display a warning, but still continue running what it possibly can parse?

I'm still seeing crashes after trying this code:

❯ ~/.pyenv/versions/3.9.1/envs/apg/bin/ansible-playbook-grapher  entry-plan.yml --include-role-tasks -i inventory/tf_inventory.py
[WARNING]: ansible.utils.display.initialize_locale has not been called, this may result in incorrectly calculated text widths that can cause Display to print incorrect line lengths

Parsing Play: generate plan order (1) **************************************************************************************************************************************************************
[WARNING]: Including role with loop is not supported for the moment. The include will not be evaluated.
Traceback (most recent call last):
  File "/home/johan/.pyenv/versions/3.9.1/envs/apg/bin/ansible-playbook-grapher", line 33, in <module>
    sys.exit(load_entry_point('ansible-playbook-grapher==1.0.1', 'console_scripts', 'ansible-playbook-grapher')())
  File "/home/johan/.pyenv/versions/apg/lib/python3.9/site-packages/ansible_playbook_grapher-1.0.1-py3.9.egg/ansibleplaybookgrapher/cli.py", line 126, in main
    cli.run()
  File "/home/johan/.pyenv/versions/apg/lib/python3.9/site-packages/ansible_playbook_grapher-1.0.1-py3.9.egg/ansibleplaybookgrapher/cli.py", line 43, in run
    playbook_node = parser.parse()
  File "/home/johan/.pyenv/versions/apg/lib/python3.9/site-packages/ansible_playbook_grapher-1.0.1-py3.9.egg/ansibleplaybookgrapher/parser.py", line 179, in parse
    self._include_tasks_in_blocks(current_play=play, parent_nodes=[role_node], block=block,
  File "/home/johan/.pyenv/versions/apg/lib/python3.9/site-packages/ansible_playbook_grapher-1.0.1-py3.9.egg/ansibleplaybookgrapher/parser.py", line 289, in _include_tasks_in_blocks
    self._include_tasks_in_blocks(current_play=current_play, parent_nodes=parent_nodes, block=b,
  File "/home/johan/.pyenv/versions/apg/lib/python3.9/site-packages/ansible_playbook_grapher-1.0.1-py3.9.egg/ansibleplaybookgrapher/parser.py", line 317, in _include_tasks_in_blocks
    parent_node=parent_nodes[-1])
IndexError: list index out of range

I can create a new issue if you'd prefer tracking this separately, just lmk.

[haidaraM]

Can you provide me a minimal version of your playbook that is failing or run with -vvv and send me the logs?

No need to create a new issue. I will reopen the old one :-)

[haidaraM]

It displays a warning and moves on to the next task but in your case, I have missed something.

[fiskhest]

To create a minimal reproducible version of my playbook I reverse engineered to understand what task is failing,

try:
    self._add_task(task=task_or_block, task_vars=play_vars, node_type=node_type,
                   parent_node=parent_nodes[-1])
except IndexError:
    breakpoint()

-> for task_or_block in block.block:
(Pdb) task_or_block
TASK: meta/plan : Include the dynamically generated resource plan
(Pdb)

- name: Include the dynamically generated resource plan
  ansible.builtin.include_vars:
    dir: "{{ tenant_dir }}/pipeline/virtual_machines/"
    name: resources
    hash_behaviour: merge

I tried to replicate the include-pasta I've created a simple role that tries to trigger the same issue but that runs as intended. The source is too complex and containing secrets that I do not wish to share. Will continue trying to replicate it minimally but I got no further ideas so leaving this here for now.

[haidaraM]

Ok. Can you try the version on this PR #99 ?

[fiskhest]

Certainly, one moment.