Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly rank the edges in the graphs and sub-graphs #104

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: Properly rank the edges in the graphs and sub-graphs #104

merged 1 commit into from
Feb 15, 2022

Conversation

haidaraM
Copy link
Owner

@haidaraM haidaraM commented Feb 12, 2022 •
edited
Loading

Fix #85
Capture d’écran 2022-02-12 à 18 18 10

@coveralls
Copy link

coveralls commented Feb 12, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 95.76% when pulling 04bfaa1 on fix/rankEdges into 554523c on main.

@haidaraM
Copy link
Owner Author

Note: this fix works for almost all cases except for blocks which use the graphviz cluster feature. Positioning cluster exactly where we want seems complex. I will see in the future If I can fix that somehow.

@haidaraM haidaraM marked this pull request as ready for review February 15, 2022 18:46
@haidaraM haidaraM merged commit d61ba1e into main Feb 15, 2022
@haidaraM haidaraM deleted the fix/rankEdges branch February 15, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] Graphviz : properly rank the edges
2 participants
@haidaraM @coveralls