Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precondition constraints should be of the shape true => pred #795

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jul 22, 2024

PR #790 was outputting pre_instance => pre_trait for precondition.
We need the opposite: the precondition of the instance should always be implied by the one defined on the trait.

@W95Psp W95Psp requested a review from karthikbhargavan July 22, 2024 14:26
@W95Psp W95Psp assigned mamonet and unassigned mamonet Jul 22, 2024
@W95Psp W95Psp requested a review from mamonet July 22, 2024 14:31
@mamonet
Copy link
Collaborator

mamonet commented Jul 22, 2024

I can confirm this PR solves the issue. Thanks, Lucas.

@W95Psp W95Psp force-pushed the pre-post-traits branch from 06b78a0 to 3096eaa Compare July 22, 2024 14:36
@W95Psp W95Psp enabled auto-merge July 22, 2024 14:36
@W95Psp W95Psp disabled auto-merge July 22, 2024 14:42
@W95Psp W95Psp self-assigned this Jul 22, 2024
@W95Psp W95Psp enabled auto-merge July 22, 2024 14:49
@W95Psp W95Psp added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit b5b9ab2 Jul 22, 2024
13 checks passed
@W95Psp W95Psp deleted the pre-post-traits branch July 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants