Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

Updates for latest rust #371

Closed
wants to merge 27 commits into from
Closed

Updates for latest rust #371

wants to merge 27 commits into from

Conversation

richo
Copy link
Contributor

@richo richo commented Mar 15, 2016

I've started trying to get Zinc working on modern rust.

I'm currently blocked on rust-lang/rust#32269 but this at least massively cuts down on the compile errors.

@@ -32,7 +32,7 @@ pub fn main() {
watchdog::init(watchdog::State::Disabled);

// Pins for MC HCK (http://www.mchck.org/)
let led1 = pin::Pin::new(pin::Port::PortB, 16, pin::Function::Gpio, Some(zinc::hal::pin::Out));
let led1 = pin::Pin::new(pin::Port::PortB, 13, pin::Function::Gpio, Some(zinc::hal::pin::Out));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'll fix this

@richo
Copy link
Contributor Author

richo commented Mar 16, 2016

This gets zing building cleanly.

I will hopefully have a look at the tests tomorrow.

@farcaller
Copy link
Member

Looks nice, thanks for your work. I'll keep this open until we get green on travis though.

@richo
Copy link
Contributor Author

richo commented Mar 16, 2016

Works for me! There's some pretty severe breakage in the way that ASTs are constructed, and my lack of familiarity with the code is making debugging hard.

If it's ok with you I'll braindump into this issue and see if anything makes more sense to you?

@farcaller
Copy link
Member

Sounds good.

@posborne
Copy link
Contributor

As an aside, we've been using homu (http://homu.io/) on nix and it has worked out pretty well. https://github.com/nix-rust/nix/blob/master/CONTRIBUTING.md#homu-the-bot-who-merges-all-the-prs. Homu will verify that the resultant merged state passes before merging into master.

@farcaller
Copy link
Member

Cool, thanks, I'll take a look at it (it's the next iteration of bors, right?)

@posborne
Copy link
Contributor

Yes, I'm not sure if it is the next generation or just the generally available version. Either way, yes -- it's basically bors.

@gyscos
Copy link

gyscos commented Mar 21, 2016

This fixes ioreg, but it seems platformtree still uses some of the old types (for instance platformtree/src/parser.rs:19 imports syntax::ast::LitInt).

@richo
Copy link
Contributor Author

richo commented Apr 15, 2016

Thanks to @gyscos I was able to build blinky_lpc17xx using rust 1.9-dev.

I'm curious to see what travis will make of the tests, but this is progressing.

@gyscos
Copy link

gyscos commented May 25, 2016

#374, already merged, includes most of the fixes present here.

@mcoffin
Copy link
Contributor

mcoffin commented Nov 21, 2016

already merged

Yep. Closing this.

@mcoffin mcoffin closed this Nov 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants