fix: use encoded note id to update history #1804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1570
In the current version, if I call
PUT /api/notes/:noteId
, my note will be updated properly, but in history page, I will get 2 notes with the same name, one linked to/uuid
(which can not be opened, 404) and the other linked to/encoded_id
(this is what I want)I did some digging, and noticed that both
note.id
andnoteId
here inupdateNote
are uuid, not encoded note id, we have to callNote.encodeNoteId
to make it work