Skip to content

Commit

Permalink
Merge pull request #92 from ardunn/master
Browse files Browse the repository at this point in the history
fix some codacy issues
  • Loading branch information
ardunn authored May 24, 2020
2 parents 9afbd3c + 059aa08 commit 80c4806
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
6 changes: 5 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ jobs:
. venv/bin/activate
coverage run setup.py test
coverage xml
python-codacy-coverage -r coverage.xml
if [[ ! -z "$CODACY_PROJECT_TOKEN" ]]; then
python-codacy-coverage -r coverage.xml
else
echo "No Codacy Project Token Defined, skipping..."
fi
- store_artifacts:
path: test-reports
Expand Down
2 changes: 1 addition & 1 deletion rocketsled/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ def is_duplicate_by_tolerance(x_new, all_x_explored, tolerances):
# todo: ...is outside of tolerance

categorical_dimensions = []
for i in range(len(x_new)):
for i, _ in enumerate(x_new):
if type(x_new[i]) not in dtypes.numbers:
categorical_dimensions.append(i)

Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
long_description = \
"""
rocketsled is a black-box optimization framework "on rails" for high-throughput computation with FireWorks.
- **Website (including documentation):** https://hackingmaterials.github.io/rocketsled/
- **Help/Support:** https://groups.google.com/forum/#!forum/fireworkflows
- **Source:** https://github.com/hackingmaterials/rocketsled
Expand All @@ -27,8 +27,8 @@
If you find FireWorks useful, please consider citing [its paper](http://dx.doi.org/10.1002/cpe.3505) as well:
```
Jain, A., Ong, S. P., Chen, W., Medasani, B., Qu, X., Kocher, M., Brafman, M.,
Petretto, G., Rignanese, G.-M., Hautier, G., Gunter, D., and Persson, K. A.
Jain, A., Ong, S. P., Chen, W., Medasani, B., Qu, X., Kocher, M., Brafman, M.,
Petretto, G., Rignanese, G.-M., Hautier, G., Gunter, D., and Persson, K. A.
FireWorks: a dynamic workflow system designed for high-throughput applications.
Concurrency Computat.: Pract. Exper., 27: 5037–5059. (2015)
```
Expand Down

0 comments on commit 80c4806

Please sign in to comment.