Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personal tempate update and otherfixes (#439) #439

Merged
merged 26 commits into from
Feb 7, 2023

Conversation

ZeroQLi
Copy link
Contributor

@ZeroQLi ZeroQLi commented Jan 27, 2023

WHAT'S UP GUYS this is ZeroQL BACK with another pull request and this today we are going to open this pull request

before we start off i would like to thank today's wonderful sponsor RAID SHADOW LEGENDS. One of the biggest mobile role-playing games of 2019 and it's totally free! Currently almost 10 million users have joined Raid over the last six months, and it's one of the most impressive games in its class with detailed models, environments and smooth 60 frames per second animations! All the champions in the game can be customized with unique gear that changes your strategic buffs and abilities! The dungeon bosses have some ridiculous skills of their own and figuring out the perfect party and strategy to overtake them's a lot of fun! Currently with over 300,000 reviews, Raid has almost a perfect score on the Play Store! The community is growing fast and the highly anticipated new faction wars feature is now live, you might even find my squad out there in the arena! It's easier to start now than ever with rates program for new players you get a new daily login reward for the first 90 days that you play in the game! So what are you waiting for? Go to the video description, click on the special links and you'll get 50,000 silver and a free epic champion as part of the new player program to start your journey! Good luck and I'll see you there!

@cfanoulis
Copy link
Member

zero is2g 😭

Copy link
Member

@cfanoulis cfanoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ZeroQLi
Copy link
Contributor Author

ZeroQLi commented Jan 28, 2023

Ok so the country commit may need some explanation

for no other reason than my internal curiosity, i decided to fetch the location of ALL 250+ members participating in hardware party and found some countries missing in the list (using their public gh api thingy you get the point)

below are the countries the associated participant, the country I've added to list and the related PR

note: some have had more than 1 participant but is that really necessary

name country related PR
wollygfx Columbia #393
WilmervH Finland #108
PasinduDushan Sri Lanka #257
mostlywhat Thailand #71
chrisrama South Africa #322
peiprjs Spain #149
SatoMasahiro2005 Japan #17
ZeroQLi United Arab Emirates #325

also is it me or does the last name look vaguely familiar 🤔

@cfanoulis cfanoulis added the zeroql made yet another pull request @zeroql's very own label label Jan 28, 2023
@ZeroQLi
Copy link
Contributor Author

ZeroQLi commented Jan 29, 2023

it seems you guys will wrap up proposals this week.

if so then keep this PR open.That way i can finish off with the fixes of other upcoming grants without needing to open another pr

@ZeroQLi
Copy link
Contributor Author

ZeroQLi commented Feb 5, 2023

can you guys solve the edit conflict, i have no clue.

@maxwofford
Copy link
Member

I don't have edit access to push to your branch! That said, we can squash this once it's ready.

@cfanoulis
Copy link
Member

@maxwofford this needs to be resolved via CLI - github complains about complexity...

@maxwofford maxwofford enabled auto-merge (squash) February 7, 2023 15:40
@maxwofford
Copy link
Member

Merging, thanks for the fix!

@maxwofford maxwofford disabled auto-merge February 7, 2023 15:40
@maxwofford maxwofford changed the title personal tempate update and otherfixes personal tempate update and otherfixes (#439)Co-authored-by: Charalampos Fanoulis <charalampos.fanoulis@gmail.com> Feb 7, 2023
@maxwofford maxwofford merged commit 64764b1 into hackclub:main Feb 7, 2023
@maxwofford maxwofford changed the title personal tempate update and otherfixes (#439)Co-authored-by: Charalampos Fanoulis <charalampos.fanoulis@gmail.com> personal tempate update and otherfixes (#439) Feb 7, 2023
@ZeroQLi
Copy link
Contributor Author

ZeroQLi commented Feb 7, 2023

awesome, thanks for fix up

I guess this is the last one, i'll prob do one last check but I've got exams and the actual hardware event going on so it'll take some time

I've made of half all the contributions i made in 2022 in january alone thanks to this repository. So thank you for letting me inflate my contribution history :p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants