Han event expanded view component issue 11 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javalosr2004
requested changes
Jan 28, 2024
javalosr2004
requested changes
Jan 28, 2024
There was a problem hiding this comment.
Nice job on fixing the media query for medium screen view ports, however, the overlap continues to show on smaller viewports, I went ahead and fixed this, I believe you will have to run git pull in order to see the changes, but can you make it so that the buttons are a little bigger on viewport sm.
I think now it looks better in small viewports, let me know if there is any adjustment you felt needed. |
javalosr2004
requested changes
Jan 30, 2024
javalosr2004
approved these changes
Feb 4, 2024
…n components and onclick to expand/collapse when clicked on anywhere of the component
…github.com/hack4impact-calpoly/slo-beaver-brigade into han-event-expanded-view-component-issue-11 Merge branch 'han-event-expanded-view-component-issue-11' of https://github.com/hack4impact-calpoly/slo-beaver-brigade into han-event-expanded-view-component-issue-11# the commit.
javalosr2004
requested changes
Feb 4, 2024
There was a problem hiding this comment.
Bugs:
- if you click on the edit or delete or any of the buttons within the modal, it closes the modal and does the operation after opening it again.
Improvements: - Can you separate the eventDetails.startTime.toLocaleTimeString, to a seperate const variable within the Page itself. possibly as multiple variables.
… buttons within the modal, it closes the modal and does the operation after opening it again.
…t constant variables
javalosr2004
requested changes
Feb 5, 2024
|
make sure to run git pull origin main, to stay up to date with changes, after you run git pull |
…ver-brigade into han-event-expanded-view-component-issue-11
…ver-brigade into han-event-expanded-view-component-issue-11
…github.com/hack4impact-calpoly/slo-beaver-brigade into han-event-expanded-view-component-issue-11
javalosr2004
approved these changes
Feb 11, 2024
javalosr2004
added a commit
that referenced
this pull request
Apr 2, 2024
…ew-component-issue-11 feat: expanded view component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: HanYu Wu
Closes #11
Pull Request Summary
Created expanded view client component and its parent component which serves as a mock data setup to showcase the EventExpandedView Component. toggleModal function is created for better modal control, content section is conditionally rendered to appear only when showExpandedView is true, which happens when clicking on the expanded icon, collapsing when clicking on the X. Sign up options, edit, and delete feature are also conditionally rendered based on the user state, everything are styled for better mobile-friendliness by utilizing Chakra UI's responsive utility.
Modifications
Added a ExpandedViewComponent.tsx, YourParentComponent.tsx, added ChakraProvider in Providers.tsx
Pull Request Checklist
Screenshots/Screencast