Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proposal table): update table columns & dummy data #60

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Robert303V
Copy link
Contributor

Developer: Robert Vermeulen

Closes #41

Pull Request Summary

Updated table columns & dummy data to reflect proposalSchema in "src/database/proposalSchema.ts"

Added two properties to proposalSchema: meeting_date & public_comment_end_date

Allowed for sorting by any column containing dates, or by name

Modifications

"src/database/proposalSchema.ts" -> added meeting_date (Date) and public_comment_end_date (Date) as arguments of IProposal object

"src/components/proposalTable.tsx" -> changed the dummy data to be of type IProposal not of type Payments

"src/lib/tableColumns.tsx" -> changed the columns to reflect the IProposal object

Testing Considerations

{list out what you have tested and what the reviewer should verify}

Pull Request Checklist

  • [X ] Code is neat, readable, and works
  • [X ] Comments are appropriate
  • [X ] The commit messages follows our guidelines
  • [X ] The developer name is specified
  • [X ] The summary is completed
  • [X ] Assign reviewers

Screenshots/Screencast

{put screenshots of your change, or even better a screencast displaying the functionality}

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ecologistics-web-scraper ✅ Ready (Inspect) Visit Preview Feb 25, 2024 7:51pm

Copy link
Collaborator

@oli-lane oli-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oli-lane oli-lane merged commit 7973513 into develop Feb 27, 2024
4 checks passed
@oli-lane oli-lane deleted the 41-rpvermeu branch February 27, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update table columns
2 participants