22 next auth routes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryanchansf
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
This looks great Sophia! The code is clean and organized, and the routes seem to interact with MongoDB well. Great job checking the API routes with Postman too. The schema looks good too — eventually we can make change to the UI to accommodate for a name field, so it's fine that we have it as optional for now. I know this was a relatively large task this week, so thank you so much for working on this! Merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Sophia Peckner
Closes #22
Pull Request Summary
Created login and sign up GET/ POST api routes
Modifications
Created three api routes for when user signs up with an email and password, to check if the user already exists, and to get a user from passed in email address.
Testing Considerations
I've tested every request on Postman.
Things to note. Name is currently an optional property in the UserSchema; I'm unsure if we want to make it required. Created users are currently being added to the users collection in the test database, I'm not sure if this should be the case.
Pull Request Checklist
Screenshots/Screencast