Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: protect login and signup page when signed in #107

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: protect login and signup page when signed in #107

merged 1 commit into from
Apr 17, 2024

Conversation

wesleytam88
Copy link
Collaborator

Developer: Wesley Tam

Closes #81

Pull Request Summary

Protects the login and signup pages when the user is signed in.

Modifications

login/page.tsx + signup/page.tsx: Add a check to see if the user is signed in, redirects to the home page if so.

Testing Considerations

  • While logged in, try to access the login and signup page
  • While not logged in, try to login and/or signup to ensure regular flow still works

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

@wesleytam88 wesleytam88 linked an issue Apr 17, 2024 that may be closed by this pull request
Make login/signup protected #81
Closed
2 tasks
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ecologistics-web-scraper ✅ Ready (Inspect) Visit Preview Apr 17, 2024 4:00am

ryanchansf
ryanchansf approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@ryanchansf ryanchansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Wesley!

@ryanchansf ryanchansf merged commit af28b16 into develop Apr 17, 2024
4 checks passed
@ryanchansf ryanchansf deleted the 81-make-loginsignup-protected branch April 17, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanchansf ryanchansf ryanchansf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make login/signup protected
2 participants
@wesleytam88 @ryanchansf