Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootcamp completion review #28

Closed
wants to merge 36 commits into from
Closed

Conversation

Amogh76
Copy link

@Amogh76 Amogh76 commented Oct 25, 2024

Developer: Amogh Arora
link: https://bootcamp-project-2024-nine.vercel.app/

Closes #1

Pull Request Summary

Completed bootcamp

Special Instructions (optional)

Pull Request Readiness Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Ask for a review in communication channels

@Amogh76 Amogh76 closed this Nov 30, 2024
@Amogh76 Amogh76 reopened this Nov 30, 2024
Copy link

gitguardian bot commented Dec 14, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 00da1ff my-app/.gitignore View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@seanmnguyen
Copy link
Collaborator

General

Please make sure to fill out the PR. Basically, you should replace every instance of curly braces.

Milestone 1

Looks great!

Milestone 2

You should import blogs from blogData.ts instead of redefining the blogs array. For better practice and readability, please use a CSS file instead of in-line styling for blog/page.tsx.

Looking at your most recent commit, you should use the getBlogs function instead of the hard-coded blogs array. I'll mark you complete for milestones 1 and 2, but please make these changes for whatever milestone you're working on now. If you fix this PR, I'll close it and you can make a new PR for milestones 3-4

@Amogh76 Amogh76 changed the title Amogh Review Request Bootcamp completion review Jan 26, 2025
@seanmnguyen
Copy link
Collaborator

Congrats on finishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone 1 - Adding Typescript
2 participants