-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lock-status #506
Conversation
Added Fixtures for lock-status command, added params to KamereonVehicleLockStatusData
Removed fixture for v2 of lock-status
Added test and schema for lock-status
fixed formating issues
Could you check the CI results and adjust accordingly? |
Fix formating and test name
It looks like the old lock file was referenced elsewhere. |
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
…t-api into lock-status_support
CI looks good - but I've had a think about it and I wonder if you could post two fixtures instead of one. |
I have another fixture with the car unlocked but, with the doors closed. I guess I can add it too, and some time later see how open doors look like too. What should be the name of a second fixture in that case? some prefix/suffix? |
I think On this line you update it to lock-status1.json: Line 378 in 680cd5a
And also you could update the documentation with the samples: This is what the documentation looks like: https://renault-api.readthedocs.io/en/latest/endpoints.html#location |
Added fixture and test for lock-status with unlocked state
Added 2nd fixture and samples to the docs. |
Looks great! Sadly my Zoe40 doesn't support the lock status so I cannot test it. When would you be able to update the 2nd fixture? |
Oh my.. Ok, I'm going out to this dark night right now to see the status with an open door. But promise me, we complete this PR today :) |
Well, it works weird: when I unlock the car, I get a new status with the new timestamp within a minute or so. Once I locked the car with all doors physically closed, I got the locked status in the API but again with all doors closed (which was true at that moment). Maybe they just did not implement it in the API or in my car in particular. |
Ah the joys of the renault API!!! |
Thanks @FRSTR ! |
👍 |
I guess next step is to add the lock-status to the CLI now that it's available on the base class... |
Added Fixtures for lock-status command, added params to KamereonVehicleLockStatusData, added test and schema for lock-status