Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue clearing schedules #1046

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Fix issue clearing schedules #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d20ba5
Fix issue clearing schedules
epenet Dec 14, 2023
4a81f37
lint
epenet Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/renault_api/kamereon/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ def update_schedule(schedule: models.ChargeSchedule, settings: Dict[str, Any]) -
if day in settings:
day_settings = settings[day]

if day_settings: # pragma: no branch
if day_settings is None:
setattr(schedule, day, None)
elif day_settings: # pragma: no branch
start_time = day_settings["startTime"]
duration = day_settings["duration"]

Expand Down
11 changes: 10 additions & 1 deletion tests/kamereon/test_kamereon_vehicle_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,20 @@ def test_charge_schedule_for_json() -> None:
{
"id": 1,
"tuesday": {"startTime": "T12:00Z", "duration": 15},
"wednesday": None,
}
)

# Monday kept initial values
assert vehicle_data.schedules[0].monday is not None
assert vehicle_data.schedules[0].monday.startTime == "T00:00Z"
assert vehicle_data.schedules[0].monday.duration == 450
# Tuesday has updated values
assert vehicle_data.schedules[0].tuesday is not None
assert vehicle_data.schedules[0].tuesday.startTime == "T12:00Z"
assert vehicle_data.schedules[0].tuesday.duration == 15
# Wednesday has values cleared
assert vehicle_data.schedules[0].wednesday is None

# Test update activated state
assert vehicle_data.schedules[1].activated
Expand All @@ -147,7 +156,7 @@ def test_charge_schedule_for_json() -> None:
"activated": True,
"monday": {"startTime": "T00:00Z", "duration": 450},
"tuesday": {"startTime": "T12:00Z", "duration": 15},
"wednesday": {"startTime": "T00:00Z", "duration": 450},
"wednesday": None,
"thursday": {"startTime": "T00:00Z", "duration": 450},
"friday": {"startTime": "T00:00Z", "duration": 450},
"saturday": {"startTime": "T00:00Z", "duration": 450},
Expand Down
Loading