Issue/64/mp_sparse_encode #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutkss
requested changes
Jul 25, 2019
| code[idx, :] = sparse_encode(X[idx, :][mask[idx, :] == 1].reshape(1, -1), | ||
| dictionary[:, mask[idx, :] == 1], | ||
| **kwargs) | ||
| code[idx, :] = sklearn.decomposition.sparse_encode( |
There was a problem hiding this comment.
@zalgo-edu In this function, sklearn.decomposition.sparse_encode is used.
This is the function in scikit learn. However, we should use sparse_encode defined by override here.
| tol : float | ||
| Maximum norm of the residual. | ||
| """ | ||
| if tol is not None and tol < 0: |
There was a problem hiding this comment.
@zalgo-edu Please make sure each vector in dictionary has norm 1.
If this condition is not satisfied, please raise warning message.
…n_unittest Issue/66/normalize dictionaries in unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement matching pursuit (MP) mode into sparse_encode function.
Related Issues/Wiki/Resources