Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the generation code of DCT dictionary #84

Open
y-iwao opened this issue Jan 17, 2020 · 1 comment
Open

Review the generation code of DCT dictionary #84

y-iwao opened this issue Jan 17, 2020 · 1 comment
Assignees
@sutkss

Comments

@y-iwao
Copy link
Contributor

y-iwao commented Jan 17, 2020

Issue Description

The DCT dictionary which is generated by the code of spm-image looks slightly different from examples found on the web.
https://seinzumtode.hatenadiary.jp/entry/20171123/1511468787

Examples found on the web look more symmetric than ours.
We should review the generation code of DCT dictionary or we should find a library which can generate DCT dictionary.
@sutkss
Copy link
Collaborator

sutkss commented Feb 7, 2020

I fixed dct problem. Now, we get the correct dct dictionary.
I attached the visualization of fixed dct dictionary
image

sutkss pushed a commit that referenced this issue Feb 7, 2020
#84 fix dct implementation
be26611
sutkss pushed a commit that referenced this issue Feb 7, 2020
#84 fix unittest for dct dictionary
5fca45d
sutkss pushed a commit that referenced this issue Feb 7, 2020
#84 fix notebook for dct modification
e98ddde
@sutkss sutkss mentioned this issue Feb 7, 2020
Merged
sutkss pushed a commit that referenced this issue Feb 7, 2020
#84 add type hinting and apply reformatter
35f89f2
kazuki1004 pushed a commit to kazuki1004/spm-image that referenced this issue Dec 25, 2020
hacarus#84 fix dct implementation
d87134e
kazuki1004 pushed a commit to kazuki1004/spm-image that referenced this issue Dec 25, 2020
hacarus#84 fix unittest for dct dictionary
138c23f
kazuki1004 pushed a commit to kazuki1004/spm-image that referenced this issue Dec 25, 2020
hacarus#84 fix notebook for dct modification
25fffb5
kazuki1004 pushed a commit to kazuki1004/spm-image that referenced this issue Dec 25, 2020
hacarus#84 add type hinting and apply reformatter
f77f71c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sutkss sutkss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sutkss @y-iwao