Bugfix/webview version upgrade #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73e4048 to
382e898
Compare
382e898 to
9ab5dfc
Compare
e271828-
reviewed
Mar 24, 2022
e271828-
approved these changes
Mar 24, 2022
https://www.npmjs.com/package/check-peer-dependencies perhaps? |
Looks exactly what we need, I will update PR later |
…react-native-hcaptcha into bugfix/webivew-version-upgrade
3f63068 to
9a1f535
Compare
|
@e271828- done |
e271828-
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Unfortunatelly I wasn't able to verify the fix, npm completely ignore peerDependency check for local modules (so I wasn't able to reproduce the issue locally)
@e271828- if you know how we can 'force' this check for local modules please let me know I will update CI