Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/themes and rqdata #11

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Feature/themes and rqdata #11

merged 10 commits into from
Mar 18, 2022

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Mar 18, 2022

Open questions

  • I suppose that custom=false param in URL will be handled correctly
  • react-native-webview has really poor error handling. In case of malformed HTML onError not triggered. Probably because of this we don't have it at all. But it will be really useful to get some errors in onMessage. I have tried this:
    <WebView
     ...
     onError={(event) => {
        event.nativeEvent.data = 'error';
        onMessage(event);
      }}
     ...
    />
    

@CAMOBAP CAMOBAP requested a review from e271828- March 18, 2022 11:49
@CAMOBAP CAMOBAP self-assigned this Mar 18, 2022
Hcaptcha.js Outdated Show resolved Hide resolved
Hcaptcha.js Outdated Show resolved Hide resolved
MAINTAINER.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@CAMOBAP CAMOBAP marked this pull request as ready for review March 18, 2022 16:05
@CAMOBAP CAMOBAP requested a review from e271828- March 18, 2022 16:05
@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Mar 18, 2022

@e271828- both rqdata and theme arguments implemented and ready for review.

Hcaptcha.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@e271828- e271828- merged commit 806c44b into master Mar 18, 2022
@e271828- e271828- deleted the feature/themes-and-rqdata branch March 18, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants