-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia: use interned strings #222
Conversation
Thanks, started juliadf now, only join task, so should be more early. From brief look, |
Thank you. This change should only affect GC time. We have not implemented the changes in CSV.jl yet, but this is the current standard approach to reduce GC time. |
taken from
|
Thank you for theis. In 1e7 case as expected there is no change (as GC is not triggered then anyway). @quinnj is finishing a PR to CSV.jl that should resolve GC issues without requiring changes in Julia Base. Then I will open another PR with a new setting of reading data in. Thank you! |
This change switches to use interned objects instead of standard strings (as standard strings are not interned) in joins.
@jangorecki - would it be possible to run the benchmarks with this change on your machine to see the impact? I changed it only for joins as it seems to be the most interesting case currently.
Thank you!