Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy fact $::hostname #3

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Remove legacy fact $::hostname #3

merged 2 commits into from
Nov 27, 2024

Conversation

klab-systems
Copy link
Contributor

@klab-systems klab-systems commented Nov 20, 2024 •
edited
Loading

  • Replace all instances of $::hostname with $facts['networking']['hostname']

fixes #2

@klab-systems klab-systems changed the title PDK Update, replace all instances of $::hostname with ['networking'][… Remove legacy fact $::hostname Nov 21, 2024
@h0tw1r3
Copy link
Owner

h0tw1r3 commented Nov 26, 2024

@klab-systems LGTM, would you mind splitting the pdk update and fix into separate commits?

@klab-systems
Copy link
Contributor Author

@klab-systems LGTM, would you mind splitting the pdk update and fix into separate commits?

Modification of legacy fact, and PDK update have now been separated into their own respective commits.

@h0tw1r3 h0tw1r3 merged commit e0781aa into h0tw1r3:main Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legacy fact still in use in realmd::join::password
2 participants
@klab-systems @h0tw1r3