-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qt 5.15.1 compatibility #434
Conversation
No, not worth changing anything simply because it is deprecated. When/if it gets removed, then we can see. They could add another replacement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What benefit does it introduce?
What I do to get rid of annoying deprecated warnings, -W-no-deprecated |
I know this is an old PR, but I'm wondering if any of the changes it introduces would fix #500 ... @nicolamori can you try compiling this outdated PR and see if works? |
…ecated QNetworkConfigurationManager
7c517ed
to
61190e5
Compare
I'm going to close this for now, we can always revive it if we decide that we need a newer Qt combability. |
This pull request adds support for Qt
5.15.1
.There is still a big problem that we need to discuss:
QProcess::startDetached(command)
has become deprecated and might be removed in future Qt versions. We need to useQProcess::startDetached(executable, arguments[])
. This prevents us from passing in the whole shell command as a whole, we are required to at least split the executable path from the arguments. This is especially problematic for the new unread counter change hook, because we allow entering the full shell command:birdtray/src/trayicon.cpp
Lines 136 to 144 in 9ff57bb
We need to be able to differentiate between the executable and the arguments. I propose adding a custom widget like this:
A click on the configure button opens a dialog that allows to configure arguments and environment variables. I based the dialog on UI elements from the JetBrains Products, which I find very intuitive to use. This would also allow us to implement #313. We could use the same widget in the
Advanced
settings tab for the Thunderbird command.@gyunaev What are your thoughts on this? I know you want to keep things as simple as possible and I think I can implement this without to much complexity. The alternative would be to just use
Utils::splitCommandLine
and hope the user doesn't input anything crazy.