Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new vector type in existing code #85

Merged
merged 17 commits into from
Feb 24, 2025
Merged

Use new vector type in existing code #85

merged 17 commits into from
Feb 24, 2025

Conversation

EmilyBourne
Copy link
Member

Use the new vector type that arises from #81 in the existing code.

This PR must be merged after #81

@EmilyBourne EmilyBourne marked this pull request as draft February 7, 2025 17:04
@EmilyBourne EmilyBourne force-pushed the ebourne_use_new_vector_type branch from aefeac5 to 73c8469 Compare February 10, 2025 09:32
@EmilyBourne EmilyBourne marked this pull request as ready for review February 10, 2025 12:09
@github-actions GitHub Actions
Copy link

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@github-actions github-actions bot marked this pull request as draft February 10, 2025 12:10
@EmilyBourne EmilyBourne force-pushed the ebourne_use_new_vector_type branch from 73c8469 to cd87c3e Compare February 17, 2025 09:58
@EmilyBourne EmilyBourne force-pushed the ebourne_use_new_vector_type branch from cd87c3e to cde9698 Compare February 17, 2025 10:05
@EmilyBourne
Copy link
Member Author

It seems that this implementation may be slower than the use of Coordinate/TaggedVector. Maybe bad luck on persee, maybe related to the comments on previous PRs

@EmilyBourne EmilyBourne force-pushed the ebourne_use_new_vector_type branch 2 times, most recently from 61db95a to 29005c6 Compare February 17, 2025 13:49
@EmilyBourne EmilyBourne force-pushed the ebourne_use_new_vector_type branch from 29005c6 to 18b63f9 Compare February 20, 2025 08:56
Base automatically changed from ebourne_tensor_type to main February 20, 2025 14:37
@EmilyBourne EmilyBourne force-pushed the ebourne_use_new_vector_type branch from 6679fa4 to 03f6fb5 Compare February 20, 2025 14:38
@EmilyBourne EmilyBourne marked this pull request as ready for review February 20, 2025 14:39
@github-actions github-actions bot marked this pull request as draft February 20, 2025 14:43
@github-actions GitHub Actions
Copy link

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@github-actions GitHub Actions
Copy link

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@EmilyBourne EmilyBourne marked this pull request as ready for review February 21, 2025 11:07
@EmilyBourne EmilyBourne added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Feb 21, 2025
yanmnc
yanmnc reviewed Feb 24, 2025
View reviewed changes
@EmilyBourne EmilyBourne requested a review from yanmnc February 24, 2025 15:55
@github-actions github-actions bot marked this pull request as draft February 24, 2025 15:58
@github-actions GitHub Actions
Copy link

It seems like you haven't finished working on this PR so it has been put back into draft. Please remove the draft status when the PR can run tests without being interrupted.

@github-actions github-actions bot removed the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Feb 24, 2025
@EmilyBourne EmilyBourne marked this pull request as ready for review February 24, 2025 16:01
@EmilyBourne EmilyBourne added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Feb 24, 2025
@EmilyBourne EmilyBourne added Ready to merge Label to be automatically added to a PR when it is approved and tests are passing and removed Ready to review Label to be automatically added to a PR when it is ready to be reviewed labels Feb 24, 2025
@EmilyBourne EmilyBourne enabled auto-merge (squash) February 24, 2025 17:02
@EmilyBourne EmilyBourne disabled auto-merge February 24, 2025 17:02
@EmilyBourne EmilyBourne enabled auto-merge (squash) February 24, 2025 17:03
@EmilyBourne EmilyBourne merged commit 3f770dc into main Feb 24, 2025
17 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_use_new_vector_type branch February 24, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanmnc yanmnc yanmnc approved these changes

Assignees
No one assigned
Labels
Ready to merge Label to be automatically added to a PR when it is approved and tests are passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilyBourne @yanmnc