Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup-miniconda actions configuration #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duncanmmacleod
Copy link
Member

This PR updates the setup-miniconda action configuration to restore cache functionality.

@eagoetz
Copy link
Collaborator

eagoetz commented Jan 7, 2025

@duncanmmacleod did the cache somehow get fixed? Also, my comments from the other thread in gwdetchar PR stand: we don't need to activate test (this happens by default) and why use miniforge when specifying conda-forge channels works? Thanks for your help!

@eagoetz
Copy link
Collaborator

eagoetz commented Jan 8, 2025

@duncanmmacleod Similar to my comment over on gwdetchar, is this PR needed since caching seems broken? It looks like the use-only-tar-bz2: true is required for caching, so this PR doesn't actually restore cache functionality, as far as I can tell. See https://github.com/conda-incubator/setup-miniconda?tab=readme-ov-file#caching-packages

@duncanmmacleod duncanmmacleod force-pushed the actions-setup-miniconda-config branch from a27f4f3 to 57c5e86 Compare January 8, 2025 18:08
@duncanmmacleod
Copy link
Member Author

@duncanmmacleod Similar to my comment over on gwdetchar, is this PR needed since caching seems broken? It looks like the use-only-tar-bz2: true is required for caching, so this PR doesn't actually restore cache functionality, as far as I can tell. See https://github.com/conda-incubator/setup-miniconda?tab=readme-ov-file#caching-packages

I think that might be a bogus statement in the docs. In the latest pipeline all of the Build and test jobs create caches. I reran one of the jobs, which then uses the cache the first run created, and everything is restored and used properly. See https://github.com/gwpy/gwsumm/actions/runs/12676464509/job/35330002826?pr=420.

See in particular the Total download: 0 B statement emitted during the Configure conda step.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.27%. Comparing base (720bd0c) to head (57c5e86).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   49.64%   49.27%   -0.38%     
==========================================
  Files          60       60              
  Lines        8823     8789      -34     
==========================================
- Hits         4380     4330      -50     
- Misses       4443     4459      +16     
Flag Coverage Δ
Linux 49.27% <ø> (-0.38%) ⬇️
macOS 49.27% <ø> (?)
python3.10 49.27% <ø> (-0.38%) ⬇️
python3.11 49.27% <ø> (-0.38%) ⬇️
python3.9 49.27% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


- name: Configure conda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
channels: conda-forge
activate-environment: test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can we revert the change of this line? By default test is activated.

Suggested change
activate-environment: test
auto-update-conda: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants