Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend triggers information when possible #393

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Jan 31, 2024

This PR adds functionality to get_triggers so that when parameters like tstart and tend are requested to be extracted from omicron trigger files (but not duration), the duration column will be computed and added to the trigger table. This also works when fstart and fend are requested (but not bandwidth or central_freq), then bandwidth and/or central_freq will be computed and added to the table.

Together with updated configuration files, https://git.ligo.org/detchar/ligo-summary-pages/-/merge_requests/395, we can see the updated version of the glitches page here: https://ldas-jobs.ligo-wa.caltech.edu/~evan.goetz/summary/day/20240101/lock/glitches/

Compare to the original page: https://ldas-jobs.ligo-wa.caltech.edu/~detchar/summary/day/20240101/lock/glitches/

The only difference is that "Peak frequency" is renamed to "Frequency" in some labels

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3f1db27) 49.96% compared to head (1341664) 49.91%.

Files Patch % Lines
gwsumm/triggers.py 21.43% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   49.96%   49.91%   -0.05%     
==========================================
  Files          60       60              
  Lines        8729     8743      +14     
==========================================
+ Hits         4361     4364       +3     
- Misses       4368     4379      +11     
Flag Coverage Δ
Linux 49.91% <21.43%> (-0.05%) ⬇️
python3.10 49.91% <21.43%> (-0.05%) ⬇️
python3.11 49.91% <21.43%> (-0.05%) ⬇️
python3.9 49.91% <21.43%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eagoetz eagoetz marked this pull request as ready for review February 3, 2024 00:51
Copy link
Collaborator

@iaraota iaraota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eagoetz eagoetz added this to the 2.2.1 milestone Feb 5, 2024
@eagoetz eagoetz merged commit a18f5e8 into gwpy:master Feb 5, 2024
9 of 10 checks passed
@eagoetz eagoetz deleted the omicron-hdf5-table branch February 5, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants