-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetworkDutyBarPlot class #389
Conversation
Here is an example with this new class. The new plot is in the second-last row. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 49.96% 49.68% -0.28%
==========================================
Files 60 60
Lines 8729 8804 +75
==========================================
+ Hits 4361 4374 +13
- Misses 4368 4430 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@eagoetz here are the O4a.3 and "O4a.4" with the modifications implemented in #392. You can see that the percentages of I did not need to add the new |
@iaraota check why |
@eagoetz here are the updated versions with the fixed percentages in the segments: O4a: https://ldas-jobs.ligo.caltech.edu/~iara.ota/summary/gps/1368975618-1389456018/segments/ |
Co-authored-by: Evan Goetz <32753745+eagoetz@users.noreply.github.com>
@eagoetz any concerns I missed in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your updates! LGTM
@iaraota Oops, I missed that you should add the new class to |
@eagoetz thank you for noticing! I updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces the NetworkDutyBarPlot class, designed to generate a bar plot showcasing the duty factor across all combinations of detectors, ranging from individual detectors to a combination of N detectors. Additionally, it enhances the segment information table by incorporating details regarding these combinations.
To illustrate, consider three detectors: H1, L1, and V1. Prior to this pull request, the segment information table in a page with
NetworkDutyPiePlot
class included rows forH1L1V1:single
,H1L1V1:double
, andH1L1V1:triple
. With this update, it incorporates new entries such asH1L1:double
,H1V1:double
, andL1V1:double
. This enhancement remains scalable for any number of detectors; for instance, with four detectors, the table will encompass all possible combinations of two and three detectors.