-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use llhoft as short type for LIGO aggregated h(t) #366
Conversation
not DMT_C00 frames
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 50.29% 50.29%
=======================================
Files 60 60
Lines 8665 8665
=======================================
Hits 4358 4358
Misses 4307 4307
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@duncanmmacleod Thanks. Is this an official change? We should no longer be using *_DMT_C00 for anything? I'll note that at LLO, I can still see both types, but the L1_llhoft are 4 second frames, not 1 second frames: [detchar@LLO-grid 13:25 ~]$ gw_data_find -o L -t L1_llhoft --latest --names-only
/archive/frames/ER8/llhoft/L1/L-L1_llhoft-11266/L-L1_llhoft-1126621180-4.gwf
[detchar@LLO-grid 13:25 ~]$ gw_data_find -o L -t L1_DMT_C00 --latest --names-only
/gds-l1/dmt/frames/hoft/L1/L-L1_DMT_C00-136777/L-L1_DMT_C00-1367777884-1.gwf |
Ping @duncanmmacleod about my question #366 (comment) |
1 similar comment
Ping @duncanmmacleod about my question #366 (comment) |
Ping @duncanmmacleod, could you check my comment and give feedback? Thank you! |
This is my reccomendation. The That's about as official as I am willing to get. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you for answering this question. LGTM
This PR patches
gwsumm.data.timeseries
to define{H1,L1}_llhoft
as the 1-second equivalent of{H1,L1}_HOFT_C00
, rather than the equivalent*_DMT_C00
frames. Thellhoft
files are the official low-latency product that are cached for a period (~1 month) on LDAS and discoverable withgwdatafind
.