Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken docs link #340

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Fix broken docs link #340

merged 1 commit into from
Oct 3, 2022

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Jul 22, 2022

Closes #179

Simply change the broken link to one that works.

@eagoetz eagoetz requested review from duncanmmacleod and removed request for duncanmmacleod July 22, 2022 00:43
@eagoetz
Copy link
Collaborator Author

eagoetz commented Jul 22, 2022

@duncanmmacleod What's the procedure for determining if docs changes work properly?

Also, it looks like https://gwsumm.readthedocs.io/en/latest/ is woefully out of date (0.1.2!). How do we update this?

@eagoetz eagoetz requested a review from duncanmmacleod July 22, 2022 00:47
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #340 (39f03ac) into master (39f03ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 39f03ac differs from pull request most recent head 5bb21cf. Consider uploading reports for the commit 5bb21cf to get more accurate results

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files          60       60           
  Lines        8658     8658           
=======================================
  Hits         4356     4356           
  Misses       4302     4302           
Flag Coverage Δ
Linux 50.31% <0.00%> (ø)
macOS 50.31% <0.00%> (ø)
python3.10 50.31% <0.00%> (ø)
python3.7 49.51% <0.00%> (ø)
python3.8 50.31% <0.00%> (ø)
python3.9 50.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@duncanmmacleod
Copy link
Member

@duncanmmacleod What's the procedure for determining if docs changes work properly?

Also, it looks like https://gwsumm.readthedocs.io/en/latest/ is woefully out of date (0.1.2!). How do we update this?

I have resync'd the webhook used by readthedocs, which seems to have kickstarted the PR builds, which is the way to test the docs changes. This in turn exposes the docs failure responsible for the out-of-date docs.

@duncanmmacleod
Copy link
Member

See #343 for a fix to the rtd builds.

@eagoetz eagoetz self-assigned this Aug 10, 2022
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified as works, thanks @eagoetz.

@eagoetz eagoetz merged commit 435d75d into gwpy:master Oct 3, 2022
@eagoetz eagoetz added this to the 2.1.1 milestone Oct 18, 2022
@eagoetz eagoetz deleted the fix-docs-link branch November 24, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link missing on the Tabs API instructions page
2 participants