Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LIGO_LW handling to use python-ligo-lw #331

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Conversation

duncanmmacleod
Copy link
Member

This PR migrates the gwsum.triggers module to use python-ligo-lw for handling LIGO_LW files, instead of glue.ligolw.

All of the actual reading is done by GWpy, so this change doesn't actually change how the files are read, but instead modifies some edge cases (e.g. empty table creation, etc).

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #331 (d7536a6) into master (bf7f1ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files          60       60           
  Lines        8658     8658           
=======================================
  Hits         4356     4356           
  Misses       4302     4302           
Flag Coverage Δ
Linux 50.31% <100.00%> (ø)
macOS 50.31% <100.00%> (ø)
python3.10 50.31% <100.00%> (ø)
python3.7 49.51% <100.00%> (ø)
python3.8 50.31% <100.00%> (ø)
python3.9 50.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gwsumm/triggers.py 65.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7f1ea...d7536a6. Read the comment docs.

Copy link
Collaborator

@eagoetz eagoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eagoetz eagoetz merged commit 06e8250 into master Jan 25, 2022
@eagoetz eagoetz deleted the python-ligo-lw branch January 25, 2022 23:17
@eagoetz eagoetz added this to the 2.1.1 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants