Fixed a few issues discovered in testing on python3 #260
Conversation
so that things aren't broken when we try to use the same table for data processing
so that we can index it with python3
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 38.84% 38.87% +0.03%
==========================================
Files 47 47
Lines 7420 7422 +2
==========================================
+ Hits 2882 2885 +3
+ Misses 4538 4537 -1
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 38.84% 38.87% +0.03%
==========================================
Files 47 47
Lines 7420 7422 +2
==========================================
+ Hits 2882 2885 +3
+ Misses 4538 4537 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 38.84% 38.87% +0.03%
==========================================
Files 47 47
Lines 7420 7422 +2
==========================================
+ Hits 2882 2885 +3
+ Misses 4538 4537 -1
Continue to review full report at Codecov.
|
| @@ -381,7 +384,7 @@ def write_state_html(self, state): | |||
| rows[-1].append('<br>'.join(assoc)) | |||
| else: | |||
| rows[-1].append('-') | |||
| page.add(str(html.table( | |||
| page.add(str(gwhtml.table( | |||
There was a problem hiding this comment.
Good catch @duncanmmacleod, I don't know how I missed this one!
There was a problem hiding this comment.
Thanks @duncanmmacleod, this all LGTM, I'll hold off merging until your testing is done
|
@alurban, I believe that no other issues have been found in testing, please merge, and tag a new release when you get a chance. Thanks. |
This PR fixes three bugs found when testing deployment with python3.