Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined plotifar #5034

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Combined plotifar #5034

merged 5 commits into from
Feb 10, 2025

Conversation

tdent
Copy link
Contributor

@tdent tdent commented Feb 6, 2025

Addresses #5006

Standard information about the request

This is a: new feature

This change affects: the offline search

This change changes: result presentation / plotting

This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Motivation

See #5006

Contents

Add a plotting script

Links to any issues or associated PRs

#5006 (again)

Testing performed

It produces a plot given exclude_zerolag files from a recent run with singles

Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this! A couple of comments, but I think this is close to being right.

bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
bin/plotting/pycbc_page_ifar_vs_stat Outdated Show resolved Hide resolved
@tdent
Copy link
Contributor Author

tdent commented Feb 8, 2025

So .. atm I have this

        logging.info(f"Ifos {exc_zlag_f.attrs['ifos']}")  # eg 'H1 L1'
        event_ifos = exc_zlag_f.attrs['ifos'].split()  # eg ['H1', 'L1']
        sig_key = ''.join(event_ifos)  # eg 'H1L1'
        coinc_key = sig_key.replace('1', '')  # eg 'HL'

are all these different forms really needed ?

@tdent
Copy link
Contributor Author

tdent commented Feb 8, 2025

Seems I was able to do without event_ifos at least.

Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there are a couple of places which might be nice to get new features, but those aren't important straight away

@tdent tdent enabled auto-merge (squash) February 10, 2025 12:02
@tdent tdent merged commit a83736d into gwastro:master Feb 10, 2025
31 checks passed
@tdent tdent added the v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
offline search v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants