Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust pygrb_page_tables #5027

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

pannarale
Copy link
Contributor

@pannarale pannarale commented Jan 30, 2025

Motivation

When recently running a light PyGRB workflow, the results webpage was not displaying the loudest onsource trigger information even though the workflow had found one. Additionally, the follow up of the trigger did not happen.

Contents

There are 2 changes in the PR.

  1. The call to load the onsource data in page_tables was asking for all timeslides (slide_id="all"), but the onsource is in zero-lag data so it now uses slide_id=0. This fixes the issue reported in the motivation.
  2. Digging through the code for the source of the issue, I spotted an if/elif structure that was heavily relying on lengths of arrays. I changed it in order to make it more robust. I should note that now this relies on the words "search" and "missed" possibily being in the hdf5 keys: if the keys structure were to change, the first if condition could become always false. However, this new structure is clear of surviving because of corner cases in array lengths.

Standard information about the request

This is a: bug fix

This change affects: PyGRB

This change changes: result presentation, scientific output

Testing performed

The run that raised the issue is available here.
The new webpage, with the fixes, is instead here.

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale pannarale added work in progress PyGRB PyGRB development labels Jan 30, 2025
@pannarale pannarale self-assigned this Jan 30, 2025
@titodalcanton titodalcanton merged commit c52c22b into gwastro:master Jan 31, 2025
30 of 31 checks passed
@pannarale pannarale deleted the page_tables_bug_and_ifelif branch February 1, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development work in progress
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants