Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When recently running a light PyGRB workflow, the results webpage was not displaying the loudest onsource trigger information even though the workflow had found one. Additionally, the follow up of the trigger did not happen.
Contents
There are 2 changes in the PR.
slide_id="all"
), but the onsource is in zero-lag data so it now usesslide_id=0
. This fixes the issue reported in the motivation.if/elif
structure that was heavily relying on lengths of arrays. I changed it in order to make it more robust. I should note that now this relies on the words "search" and "missed" possibily being in the hdf5 keys: if the keys structure were to change, the first if condition could become always false. However, this new structure is clear of surviving because of corner cases in array lengths.Standard information about the request
This is a: bug fix
This change affects: PyGRB
This change changes: result presentation, scientific output
Testing performed
The run that raised the issue is available here.
The new webpage, with the fixes, is instead here.