Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pygrb webpage is generated after all results files are produced #5025

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

pannarale
Copy link
Contributor

PyGRB webpages often had gaps that could be fixed by running the pycbc_make_html_page job by hand, after a full workflow was completed. This was a sign of incorrect dependencies in the workflow (i.e., pycbc_make_html_page was being called too early).

To fix this, this PR simply moves the call to make_results_web_page further down in the pycbc_pygrb_results_workflow workflow generator, so that the job dependencies are correct: all nodes that will give jobs that produce plots, tables, etc. are now in the collection of dependencies passed to make_results_web_page, so pycbc_make_html_page runs after those jobs.

This is a: bug fix.

This change affects: PyGRB

I produced this results webpage from a short workflow with no need to "sync" it by hand after the workflow had finished running.

  • The author of this pull request confirms they will adhere to the code of conduct

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…oduced
@pannarale pannarale added bug PyGRB PyGRB development labels Jan 30, 2025
@pannarale pannarale self-assigned this Jan 30, 2025
Copy link
Contributor

@sebastiangomezlopez sebastiangomezlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@pannarale pannarale merged commit 1273389 into gwastro:master Jan 30, 2025
30 of 31 checks passed
@pannarale pannarale deleted the pygrb_webpage_dependencies branch January 30, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PyGRB PyGRB development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants