Use glue.ligolw again #2221
Merged
Use glue.ligolw again #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 👍 |
|
Due to the huge number of issues resolved by removing a large block of code, I cannot see the 4 new issues that codeclimate is reporting. |
|
@spxiwh I will ignore that issue for this PR. Travis needs to pass though. |
ahnitz
approved these changes
Jun 29, 2018
pannarale
pushed a commit
to a-r-williamson/pycbc
that referenced
this pull request
Jul 23, 2018
* Remove pycbc.ligolw * Work with new table format * What is going on here?!? * Updating to glue changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the horrible pycbc.ligolw, which had been introduced temporarily while moving back to the official glue repository.
I've also identified, and fixed, the issue that was causing waveforms to fail when generated using the SimInspiral objects generated through XML reading in glue.ligolw. the
test_injectionscript in the test suite is a good way to test this problem.@lpsinger Pinging you here as you had identified this as one of the hurdles towards python3 support in PyCBC.