Update package exports #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alex-saunders for the fix here! I've pushed out a 0.3.16, great to hear it's working for you otherwise. And can you believe I wrote those docs 🤦♂ .... (https://github.com/nodejs/node/blame/master/doc/api/esm.md#L229) |
|
Ha! I'll excuse you this time around 😆 Cheers for merging and the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
package.jsonexports field to include valid paths (starting with./) as currently the exports are not following the spec (defined here https://nodejs.org/api/esm.html#esm_package_exports)We're trying to use
es-module-lexerin snowpack but the current exports are breaking on Node 13 (you can see the full issue here FredKSchott/snowpack#208) so hopefully this should fix that issue for us and others!