-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to download price data in EUR and other fiat currencies #43
Conversation
Great changes @giocaizzi 👍 🍰. Maybe it now would be great if we can include fiat in the default filename core.py#L228 |
good idea! 👍 i have added fiat in the default filename and modified the commented line just above it for clarity. core.py#L191-L194 |
@giocaizzi I guess we need to do similar changes on core.py#L230-L231 p.s. |
oops, got confused between the two methods. added the same changes to |
great changes @giocaizzi, thanks 😃 🎉 🍰 |
@guptarohit when are you planning on releasing? I would really appreciate if this feature was available in the release on pypa 🚀 |
hey, I am planning to add GitHub actions for ci/cd to make releases with less friction, will do it very soon |
hey @giocaizzi, FWIW these changes are now released on PyPI. 🙂 ✌️ |
@guptarohit great! Thanks 👍 |
Fixes issue:
Fixes issue of being able to download price data only in USD.
Changes:
cryptocmd.utils.download_coin_data
has new argumentfiat
, a string code to specify that price data is returned in the desired fiat currency eg. USD, EURcryptocmd.core.CmcScraper
has new attributefiat
. Default isUSD
but can now be changed during initialization.