Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to download price data in EUR and other fiat currencies #43

Merged
merged 5 commits into from
Jan 30, 2022
Merged

allow to download price data in EUR and other fiat currencies #43

merged 5 commits into from
Jan 30, 2022

Conversation

giocaizzi
Copy link
Contributor

Fixes issue:
Fixes issue of being able to download price data only in USD.

Changes:

  • cryptocmd.utils.download_coin_data has new argument fiat, a string code to specify that price data is returned in the desired fiat currency eg. USD, EUR
  • cryptocmd.core.CmcScraper has new attribute fiat. Default is USD but can now be changed during initialization.

@guptarohit
Copy link
Owner

Great changes @giocaizzi 👍 🍰. Maybe it now would be great if we can include fiat in the default filename core.py#L228

@giocaizzi
Copy link
Contributor Author

good idea! 👍 i have added fiat in the default filename and modified the commented line just above it for clarity. core.py#L191-L194

@guptarohit
Copy link
Owner

guptarohit commented Jan 29, 2022

@giocaizzi I guess we need to do similar changes on core.py#L230-L231

p.s. export_csv method is going to be deprecated.

@giocaizzi
Copy link
Contributor Author

oops, got confused between the two methods. added the same changes to export.

@guptarohit
Copy link
Owner

great changes @giocaizzi, thanks 😃 🎉 🍰

@guptarohit guptarohit merged commit 86ed81f into guptarohit:master Jan 30, 2022
@giocaizzi
Copy link
Contributor Author

@guptarohit when are you planning on releasing? I would really appreciate if this feature was available in the release on pypa 🚀

@guptarohit
Copy link
Owner

@guptarohit when are you planning on releasing? I would really appreciate if this feature was available in the release on pypa 🚀

hey, I am planning to add GitHub actions for ci/cd to make releases with less friction, will do it very soon

@guptarohit
Copy link
Owner

hey @giocaizzi, FWIW these changes are now released on PyPI. 🙂 ✌️

@giocaizzi
Copy link
Contributor Author

@guptarohit great! Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants