-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filesystem.hpp, add support for Haiku #163
Conversation
Don't merge yet, need to see if I can find a way to link it to libnetwork on Haiku (for bind and socket). |
https://github.com/gulrak/filesystem/blob/master/cmake/GhcHelper.cmake#L48 Add something like:
|
You may also need for the second macro, depends which part(s) require libnetwork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few style comments.
They apply multiple times, I didn't repeat them.
Should be OK now, did a clean build on Haiku with this PR as a patch, ran the tests (95% passed), only thing I'm missing is an option to disable Werror, but got a fix for that from Gentoo: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-cpp/gulrak-filesystem/gulrak-filesystem-1.5.12.ebuild#n22 |
Would be nice if this gets merged before a new release: #164 :) Created a PR at haikuports to have this available on Haiku: haikuports/haikuports#7865 |
Looks good to me. If the pipeline goes through, I'll merge it. Thanks for the work! |
No description provided.