Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #80

Closed
wants to merge 2 commits into from
Closed

Bump dependencies #80

wants to merge 2 commits into from

Conversation

shinnn
Copy link
Contributor

@shinnn shinnn commented Sep 14, 2016

glob-stream becomes modern Stream3 implementation by this PR.

@phated
Copy link
Member

phated commented Sep 14, 2016

Thanks. I am trying to solve some other problems before bumping the dependencies. Going to close this and do it once I land the other changes.

@phated phated closed this Sep 14, 2016
@shinnn
Copy link
Contributor Author

shinnn commented Sep 14, 2016

OK. But please remember that this commit is essential to upgrade to Stream3.

Or, should I remove the last commit and rename this PR to "Pass data to the stream correctly"?

@phated
Copy link
Member

phated commented Sep 14, 2016

TBH, this probably shouldn't even be using a Transform stream since it is using it like a readable. I need to investigate more.

@phated
Copy link
Member

phated commented Sep 16, 2016

@shinnn some initial work at 8260e0a but I'm waiting for some answers to questions from isaacs on node-glob and I need to refactor the tests because they expect an end event without being drained right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants