composer.json, package.json #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey ! Thanks for the PR I won't merge because I think it does not fit the project's needs but I will comment in this PR to explain why |
| @@ -6,7 +6,7 @@ APP_URL=http://localhost:8000 | |||
| LOG_CHANNEL=stack | |||
|
|
|||
| DB_CONNECTION=mysql | |||
| DB_HOST=mysql | |||
There was a problem hiding this comment.
mysql is actually the docker service so we can't change that
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "yarn development", | |||
| "dev": "yarn run development", | |||
There was a problem hiding this comment.
you can actually run scripts with yarn without the run keywork, it does not work with npm only
| @@ -0,0 +1,8 @@ | |||
| .vjs__tree .vjs__tree__content{border-left:1px dotted hsla(0,0%,80%,.28)!important}.vjs__tree .vjs__tree__node{cursor:pointer}.vjs__tree .vjs__tree__node:hover{color:#20a0ff}.vjs__tree .vjs-checkbox{position:absolute;left:-30px}.vjs__tree .vjs__value__boolean,.vjs__tree .vjs__value__null,.vjs__tree .vjs__value__number{color:#a291f5!important}.vjs__tree .vjs__value__string{color:#dacb4d!important}.hljs-addition,.hljs-keyword,.hljs-selector-tag{color:#8bd72f}.hljs-doctag,.hljs-meta .hljs-meta-string,.hljs-regexp,.hljs-string{color:#dacb4d}.hljs-literal,.hljs-number{color:#a291f5!important} | |||
There was a problem hiding this comment.
We don't need to hardcore this files because they are in the installation process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In order to help, I would like to propose some changes to your laravel-blog app.
When I was trying to clean cache, this action was prohibited. So, I have removed the permission deny by creating data directory in storage/framework/cache/data.
2.composer.json
the name should be vendor’s name laravel/laravel.
package.json.
It is impossible to run yarn because the ‘run’ command is missing in the package.json file.
So I have added it too.
Hope, this minor changes will be helpful.