Add AlphaName custom validation rule, replace alpha_dash with AlphaName in UserRequest name rules for admin and non-admin requests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me in UserRequest name rules for admin and non-admin requests.
|
Ok it looks nice, I will check it this evening, thanks ! |
|
Sure, glad to give back. I'm not sure the included validation strings are the best way to convey how the user can avoid the error, but describing the pattern seemed wordy and complicated. |
|
I commited some little changes that you can find here : #39 Thanks for your PR ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #37 for discussion: #37