Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #604 Toplevel repaint. #605

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fixes #604 Toplevel repaint. #605

merged 2 commits into from
Jun 3, 2020

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jun 3, 2020

No description provided.

@tig
Copy link
Collaborator

tig commented Jun 3, 2020

I am opposed to hacks like this. I understand that this fixes this one toplevel repaint issue, but it does so by mis-using the way the APIs in the project are designed.

We must fix the underlying design instead. At least that's my opinion.

@BDisp
Copy link
Collaborator Author

BDisp commented Jun 3, 2020

Even if we have to repaint the entire window to repaint a small fraction?

@tig
Copy link
Collaborator

tig commented Jun 3, 2020

Note, that this PR does not fix situations where dragging Windows doesn't repaint when the Toplevel that is underneath is NOT Application.Top.

Windows & FrameViews illustrates this.

But this PR fixes the specific issue called out, so we should merge it and open another for this other issue.

@tig
Copy link
Collaborator

tig commented Jun 3, 2020

Nice work. Sorry about pushing back so hard; I hope you understand why.

@tig tig merged commit 6631a0f into gui-cs:master Jun 3, 2020
@BDisp
Copy link
Collaborator Author

BDisp commented Jun 3, 2020

Nice work. Sorry about pushing back so hard; I hope you understand why.

Never mind. We'll see that after. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants