-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3930 - Splits tests to Tests/UnitTests
, Tests/IntegrationTests
, Tests/StressTests
#3954
Open
tig
wants to merge
73
commits into
gui-cs:v2_develop
Choose a base branch
from
tig:v2-3952_Test_Failures
base: v2_develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,738
−1,083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another result (after tyring to fix stuff):
|
…3952_Test_Failures
…3952_Test_Failures
Added Directory.Build.props
Tests/UnitTests
, Tests/IntegrationTests
, Tests/StressTests
Moved all obviously parallelizable tests. Updated yml.
Closed
…3952_Test_Failures
…3952_Test_Failures
…3952_Test_Failures
Perhaps this refactoring has hidden the root bug that was causing the crash, but I've not gotten a failure in 3 runs. Please review so I can merge and we can leverage all of this. THanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes/Todos
Tests/UnitTests
,Tests/IntegrationTests
,Tests/StressTests
Directory.Build.props
to unify settingsDirecotry.Packages.props
to unify package versions./Tests/UnitTestsParallelizable
project and move obviously parallelizable tests.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)