Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3941 - v2win/v2net: UICatalog crash - Fixes warnings #3946

Open
wants to merge 24 commits into
base: v2_develop
Choose a base branch
from

Conversation

tig
Copy link
Collaborator

@tig tig commented Mar 1, 2025

Fixes

Proposed Changes/Todos

  • See if adjusting the UI Catalog demo key pacing will fix

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
Copy link
Collaborator Author

tig commented Mar 2, 2025

@tznind - I wonder if this is why we have sporadic test failures in CI, there is All_Scenarios_Benchmark and a stack overflow might cause the behaviour we see.

FWIW, I think I saw one failure after I implemented #3946. So I'm not declaring victory on #3930 yet.

But I think this does fix #3941

@tig tig requested a review from tznind March 2, 2025 00:09
@tig tig changed the title Fixes #3941 - Fixes #3941 - v2win/v2net: UICatalog full benchmark suite crashes in Dialogs scenario Mar 2, 2025
@tig tig changed the title Fixes #3941 - v2win/v2net: UICatalog full benchmark suite crashes in Dialogs scenario Fixes #3941 - v2win/v2net: UICatalog crash - Fixes warnings Mar 2, 2025
@tig
Copy link
Collaborator Author

tig commented Mar 2, 2025

FWIW, #3930 is not related to this; still happens with the benchmark scenario test disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2win/v2net: UICatalog full benchmark suite crashes in Dialogs scenario
3 participants